fix(devtools): drop stale visibility assertion from nuxt-group e2e test#1042
Merged
Conversation
feat(devtools)!: make embedded dock the only client mode (#1041) disabled the nuxt:devtools anchor's `visibility: 'false'` (its render-only hiding breaks the Nuxt group button's defaultChildId fallback) but left the e2e test asserting the old value, failing e2e on every push to main since.
Deploying nuxt-devtools with
|
| Latest commit: |
8957945
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://93137835.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://purple-areas-win.nuxt-devtools.pages.dev |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Nuxt devtools E2E test updates its handling of the Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2ehas been failing on every push tomainsince #1041. That PR disabledthe
nuxt:devtoolsanchor's render-onlyvisibility: 'false'(it broke theNuxtgroup button'sdefaultChildIdfallback, which looks the anchor upthrough the same visibility filter), but left
nuxt-group.spec.tsassertingthe old
visibility: 'false'value in the same commit — so every e2e runacross all four playgrounds failed on that assertion.
This drops the stale assertion and expands the comment to explain why
visibility: 'false'is currently disabled inmodule-main.tsand whatneeds to happen upstream before it (and this assertion) can be restored.
Verification
pnpm buildPW_PROJECT='*:dev' pnpm test:e2e:dev --grep nuxt-group— passes acrossempty,spa,tab-pinia,tab-seo🤖 Generated with the help of an agent.